Skip to content

[components][driver/pin.c]pin 框架增加 rt_pin_get#3897

Merged
BernardXiong merged 2 commits into
RT-Thread:masterfrom
yangjie11:yj_dev1
Sep 11, 2020
Merged

[components][driver/pin.c]pin 框架增加 rt_pin_get#3897
BernardXiong merged 2 commits into
RT-Thread:masterfrom
yangjie11:yj_dev1

Conversation

@yangjie11

@yangjie11 yangjie11 commented Sep 11, 2020

Copy link
Copy Markdown
Contributor

拉取/合并请求描述:(PR description)

[
PIN 框架增加 rt_pin_get ,传入字符串后在驱动中进行解析,如 PA.0;
初始化 BSP 中的 rt_pin_ops pin_get;
实现了stm32 pin_get 驱动,实现了 lpc54114-lite pin_get 驱动;
在 pandora上测试通过,在 lpc54114-lite 上测试通过;
]

以下的内容不应该在提交PR时的message修改,修改下述message,PR会被直接关闭。请在提交PR后,浏览器查看PR并对以下检查项逐项check,没问题后逐条在页面上打钩。
The following content must not be changed in submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use web browser to visit PR, and check items one by one, and ticked them if no problem.

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other style
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 本拉取/合并请求代码是高质量的 Code in this PR is of high quality

@yangjie11 yangjie11 changed the title [] [components][driver/pin.c]pin 框架增加 rt_pin_get Sep 11, 2020
@yangjie11 yangjie11 mentioned this pull request Sep 11, 2020
8 tasks
@BernardXiong BernardXiong merged commit 36cb434 into RT-Thread:master Sep 11, 2020
@yangjie11 yangjie11 deleted the yj_dev1 branch November 20, 2020 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants